test(start): add implicit $start source state scenarios - #29
Merged
Merged
Conversation
Add implicit-start-lab: two Initial-less flows (start -> wizard, and a SubFlow child) plus a parent that declares Initial (regression side), and ImplicitStartLabTests (6 tests / 7 cases): sync start lands on the target with first history row from $start, async start + state polling, completion, Initial-less SubFlow child completing its parent, and publish refusing two Initial states and a missing/empty start target (400 App:900006). Known red against runtime 21d6875e: a sync=false start of an Initial-less flow returns 500 because JobName.ValidateKey rejects '$' in the source state '$start', leaving an orphaned instance in $start/A. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The sync=false start 500 this scenario found (JobName rejected '$' in the '$start' source state) is fixed in vnext 860c4a26. Replace the known-red notes in the scenario README and the TEST-SCENARIOS row with a history line and the 7/7 result; note that the async test's $start guard rarely fires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
◈ PR LensNote The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
implicit-start-labscenario. It proves end to end that a flow can omit the Initial state: the instance is born at$startand the start transition takes it to its target.$. It is fixed in vnext860c4a26.Changes
core/Workflows/implicit-start-lab/: three flows.implicit-start-lab(no Initial, start → wizard) and-child(no Initial) are Initial-less;-parentdeclares an Initial (regression side) and starts the child with a SubFlow. Includes the builder script and the SubFlow mapping.tests/Core.IntegrationTests/Tests/ImplicitStartLab/: 7 cases and a README.TEST-SCENARIOS.md: feature matrix row.Test Plan
--filter FullyQualifiedName~ImplicitStartLab→ 7/7.Integration test evidence
860c4a26atVNEXT_BASE_URL=http://localhost:4201(run-docker.sh up core).fromState = $start(lab flow and child); two Initials → 400 "at most one initial state"; a missing or empty start target → 400App:900006.TEST-SCENARIOS.mdrow added: yes.Notes
npm run validaterejects these flows; it only passes with the unreleased local schema.TaskInvocationLabDaprService_ProjectionShapefails on every run.🤖 Generated with Claude Code