Repository navigation
test(display-labels-lab): pin labels and target state on read surfaces - #30
Merged
Merged
Conversation
New scenario for burgan-tech/vnext-client-sdk-core#43: the state function describes the displayed state (stateType, stateSubType, stateLabels) and every transition's target with one object { key, stateType, stateSubType, labels, subFlow }, $self resolved; the timeout block's target uses the same object; the view, schema, master and catalog functions, followed through the state body's own links, return their component's labels; during the subflow window the parent describes the child's state. 3/3 green on the locally built runtime. TimeoutLab read timeout.target as a string; it now reads target.key and also asserts that a parent override's target resolves in the child's own definition (finish/timeout). 4/4 green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
◈ PR LensNote The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
carries the display text of what it describes.
timeout.targetcontract change (string → object).Changes
core/Workflows/display-labels-lab/(+ child flow, generatorbuild-display-labels-lab.py),core/Views/display-labels-lab/,core/Schemas/display-labels-lab/; the catalog check reusesthe already-labelled
til-cached-echofunction.Tests/DisplayLabelsLab(3 tests): state/transition/target/timeout descriptors; view, schema,master and catalog labels reached through the state body's own hrefs; the parent describing the
child's state during the subflow window.
Tests/TimeoutLab: readstarget.keyand asserts that a parent override's target resolves inthe child's own definition (
finish/timeout).TEST-SCENARIOS.md: new row + TimeoutLab status; scenario README.Test Plan
dotnet test tests/Core.IntegrationTests --settings tests/Core.IntegrationTests/test.runsettings --filter "FullyQualifiedName~DisplayLabelsLab"TimeoutLabnpm run validate: the new components are valid; the 32 remaining failures arepre-existing files.
Integration test evidence
0556eda0+feature/transition-labels-targetworking tree (=4e357147) atVNEXT_BASE_URL=http://localhost:4201(the two reds were the string read of
timeout.target)TEST-SCENARIOS.mdrow added/updated: yesNotes
TimeoutLab's updated assertions fail.
transition, so the review states are Initial and every transition is labelled; the "no labels
⇒ field omitted" case is pinned by vnext unit tests.
🤖 Generated with Claude Code