Repository navigation
test(parallel-variable-key-lab): pin variableKey slots and the slot-aware parallel merge - #32
Merged
Merged
Conversation
…variableKey Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and suite regression check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…earlier slot Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note The title starts with
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallel-variable-key-labfor fix(tasks): keep parallel task responses apart with variableKey and a slot-aware merge vnext#1072: the same SubProcess task (pvk-spawn-child, TaskType 14) runs twice at oneorder, each entry with its ownvariableKey, and a later entry with novariableKeykeeps the legacyToVariableName(task.key)slot.pvk-reusepins the slot-aware merge: a parallel group at order 2 re-writes the slot order 1 left behind and overwrites it instead of faulting withParallel tasks produced conflicting output.core/, pin the publish rules: same order with novariableKey, the samevariableKeytwice, and a malformedvariableKeyare all rejected with 400.Changes
core/Tasks/parallel-variable-key-lab/:pvk-spawn-child(SubProcess →pvk-child),pvk-record-slots(Script).core/Workflows/parallel-variable-key-lab/:pvk-parent,pvk-reuse,pvk-child(all 1.0.0), generated bybuild-parallel-variable-key-lab.pyfromsrc/*.csx.tests/Core.IntegrationTests/Tests/ParallelVariableKeyLab/:ParallelVariableKeyLabTests(5 tests) + README.TEST-SCENARIOS.md:parallel-variable-key-labrow.Test Plan
npm run validate: all new components ✓ Valid. The total failure count (32 files) is unchanged from master.dotnet build tests/Core.IntegrationTests0 errors.Integration test evidence
Tests/ParallelVariableKeyLab(--filter FullyQualifiedName~ParallelVariableKeyLab).feature/task-variable-keyat8046dbd6, then8f11acfcafter merging master;VNEXT_BASE_URL=http://localhost:4201(run-docker.sh up core, local build).cddab84c: 0/5.pvk-reuseandpvk-parentFaulted withParallel tasks produced conflicting output for key 'pvkSpawnChild', and the publish probes answered 200.waiting.FullyQualifiedName!~CrossDomainLab): 357/38/9 (404). All 29 distinct reds are also red on master, so there is no new red.TEST-SCENARIOS.mdrow added/updated: yes.Notes
variableKeyon the current@burgan-tech/vnext-schema, becauseonExecuteTaskhas noadditionalProperties: false. The field itself ships in feat(task): add optional variableKey to task entries vnext-schema#149.pvk-childinstances inwaiting.🤖 Generated with Claude Code