Conversation
andreiltd
requested review from
tschneidereit and
vados-cosmonic
as code owners
September 16, 2026 06:06
andreiltd
marked this pull request as draft
September 16, 2026 06:23
andreiltd
force-pushed
the
bump-js-bindgen
branch
3 times, most recently
from
September 16, 2026 15:33
022f438 to
1a04a23
Compare
This updates component bindgen to v2. The newer call generation path relies on host-side task setup. Our generated bindings run inside the SpiderMonkey wasm guest, where the native embedding already manages execution and call lifetimes - that is why this patch introduces embedding adapter for handling calls, returns and borrows locally.
andreiltd
force-pushed
the
bump-js-bindgen
branch
from
September 16, 2026 15:34
1a04a23 to
9aad095
Compare
andreiltd
marked this pull request as ready for review
September 16, 2026 15:34
Member
Author
|
Hey @vados-cosmonic, could you give this review when you have a moment? 🙏 |
vados-cosmonic
approved these changes
Sep 18, 2026
vados-cosmonic
left a comment
vados-cosmonic
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
Sorry for the delay here @andreiltd !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates component bindgen to v2. The newer call generation path relies on host-side task setup. Our generated bindings run inside the SpiderMonkey wasm guest, where the native embedding already manages execution and call lifetimes; wew
js-component-bindgenexposesskip_fn_call_task_management()exactly for this purpose.fixes: #350