fix(bindgen): deconflict instantiation helper locals from WIT import names - #2135
Open
GreenBusDriver wants to merge 1 commit into
Open
GreenBusDriver wants to merge 1 commit into
GreenBusDriver wants to merge 1 commit into
Conversation
GreenBusDriver
requested review from
andreiltd and
vados-cosmonic
as code owners
September 19, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2134
The
instantiate()/$inithelper hard-coded its locals (promise,resolve,reject,gen,runNext, ...) as literal text, so a componentimporting a WIT function with one of those names produced JS that fails to
load with
Identifier 'reject' has already been declared.Allocate the helper locals through
LocalNameslike every other generatedbinding, so the collision is resolved as
reject$1automatically.Zulip link: #jco > reject/resolve import name collision w instantiation helper @ 💬