Update spec test suite submodule - #2667
Merged
alexcrichton merged 2 commits intoSep 17, 2026
Merged
Conversation
This commit updates both the core wasm and the component model spec test suites. This drops a number of FAIL directives for component-model tests now that the upstream tests have updated. This then additionally fills out some various corners/holes for core wasm such as * The `extended-name-section` proposal's tests are new and now run here. The main test added, though, is marked as expected to fail for now. Most of the test passes but there's a few minor ones that don't round-trip correctly just yet. * Parsing of `name` sections, subsections, and maps now all have extra validation applied while parsing. Namely subsections must be ordered and maps-of-names must all be ordered correctly. * Validation for the `custom-descriptors` proposal has been adjusted to handle new tests that are added. * The `assert_malformed_custom` directive now actually parses all custom sections to look for an error. Previously it just encoded into bytes but this was an insufficient check. * Roundtripping modules with invalid custom sections is disabled because the `name` section, when invalid, doesn't roundtrip.
* Be sure to sort names by index * Don't duplicate-ly name a function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates both the core wasm and the component model spec test suites. This drops a number of FAIL directives for component-model tests now that the upstream tests have updated. This then additionally fills out some various corners/holes for core wasm such as
The
extended-name-sectionproposal's tests are new and now run here. The main test added, though, is marked as expected to fail for now. Most of the test passes but there's a few minor ones that don't round-trip correctly just yet.Parsing of
namesections, subsections, and maps now all have extra validation applied while parsing. Namely subsections must be ordered and maps-of-names must all be ordered correctly.Validation for the
custom-descriptorsproposal has been adjusted to handle new tests that are added.The
assert_malformed_customdirective now actually parses all custom sections to look for an error. Previously it just encoded into bytes but this was an insufficient check.Roundtripping modules with invalid custom sections is disabled because the
namesection, when invalid, doesn't roundtrip.