Trim readdir implementation to what WASI needs - #14348
Merged
Merged
Conversation
This commit trims down the implementation of reading directories in `wasmtime_wasi::filesystem::primitives` to what WASI needs, notably just the ability to get the file type and file name. This removes a number of layers of abstraction which would issue more syscalls than necessary for this particular use case.
dicej
approved these changes
Sep 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
alexcrichton
enabled auto-merge
September 16, 2026 18:26
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit trims down the implementation of reading directories in
wasmtime_wasi::filesystem::primitivesto what WASI needs, notably just the ability to get the file type and file name. This removes a number of layers of abstraction which would issue more syscalls than necessary for this particular use case.