Fix stack overflow translating huge variant - #14355
Merged
alexcrichton merged 1 commit intoSep 18, 2026
Merged
Conversation
This commit fixes a stack overflow when translating a variant from one component to another when it contains more than 1000 cases. This caused FACT to determine that an outlined helper was necessary but the helper ended up just delegating to itself since it determined that there wasn't ever enough fuel to translate the variant. The fix here is to treat the initial-fuel case as special and always able to translate at least one type to ensure that some translation progress is always made. Closes bytecodealliance#14354
dicej
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a stack overflow when translating a variant from one component to another when it contains more than 1000 cases. This caused FACT to determine that an outlined helper was necessary but the helper ended up just delegating to itself since it determined that there wasn't ever enough fuel to translate the variant. The fix here is to treat the initial-fuel case as special and always able to translate at least one type to ensure that some translation progress is always made.
Closes #14354