Skip to content

fix(ci): pin codecov-action v7.0.0 and enforce the CLI signature check (LAB-3433) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
27Bslash6 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ci): pin codecov-action v7.0.0 and enforce the CLI signature check (LAB-3433) #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9c9790
fix(ci): pin codecov-action v7.0.0 and enforce the CLI signature chec…
27Bslash6 Sep 12, 2026
b7b46a9
docs(ci): sharpen the codecov signature-guard note (LAB-3433)
27Bslash6 Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,21 @@ jobs:
- name: Test with coverage
run: pnpm test:coverage

# fail_ci_if_error is also the wrapper's signature-enforcement switch: with
# false, a failed `gpg --verify` of the CLI's SHA256SUM is only logged and
# the unverified binary still executes — which v6.0.0 did on every run after
# Codecov moved its public key off the keybase account v6.0.0 fetched it
# from (codecov/codecov-action#1956, 2026-06-07). Keep it true so the step
# aborts before exec; continue-on-error keeps the upload from reddening CI.
# When this step is orange, read the log: "Could not verify signature" is
# the guard working (never silence it); an upload error (token, network)
# only loses that upload.
- name: Upload coverage
uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0
continue-on-error: true
with:
files: ./packages/cachekit/coverage/lcov.info
fail_ci_if_error: false
fail_ci_if_error: true

security:
runs-on: ${{ github.event.pull_request.head.repo.fork && 'ubuntu-latest' || 'cachekit-lean' }}
Expand Down
Loading