Skip to content

Add missing test scenarios for knowledge-base feature files - #92

Merged
lihaojie-CMCC merged 14 commits into
mainfrom
lihaojie-CMCC-patch-1
Nov 11, 2026
Merged

lihaojie-CMCC merged 14 commits into
mainfrom
lihaojie-CMCC-patch-1

Conversation

@lihaojie-CMCC

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

As reported in #87, the previous split of knowledge-base.feature resulted in several mandatory test scenarios being missing across the newly divided files. Additionally, some specific operations required deeper coverage (e.g., PATCH semantics, boundary values).

Which issue(s) this PR fixes:

Fixes #87

Special notes for reviewers:

We have updated all 14 knowledge-base-*.feature files to ensure complete and compliant coverage.

1. General Mandatory Scenarios (Applied across files)

To align with CAMARA requirements, the following scenarios are now included where applicable:

  • 400 invalid x-correlator and 400 request-body strictness (unknown properties).
  • 401 Unauthorized covering all three variations: no_authorization_header, no_access_token, and expired_access_token.
  • 403 missing scope and 404 not found for the respective operations.
  • Lifecycle verification: Added create/update → get scenarios to verify state persistence.
2. Specific Extended Coverage
  • updateKnowledgeBase / updateTool:
    • Added PATCH semantic verification using Scenario Outline to ensure omitted fields are left unchanged (not cleared), as explicitly documented in the OAS.
    • Added value boundary tests (e.g., name at maxLength boundary returns 200, exceeding maxLength returns 400).
  • uploadDocument:
    • Added Scenario Outline to verify all 3 processing_status values (PROCESSING, READY, FAILED).
    • Clarified test data for 400 (malformed document format) vs 415 (unsupported MIME type) to avoid overlap.
    • Added request-body strictness check for undeclared multipart form parts.

@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 31 hints | Profile: standard

View full results

@lihaojie-CMCC
lihaojie-CMCC merged commit b3d0063 into main Nov 11, 2026
3 checks passed
@lihaojie-CMCC
lihaojie-CMCC deleted the lihaojie-CMCC-patch-1 branch November 11, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Findings in test scenarios for knowledge-base.yaml

1 participant