Skip to content

Add missing test scenarios for qa-assistant-service.feature - #93

Merged
lihaojie-CMCC merged 1 commit into
mainfrom
lihaojie-CMCC-patch-1
Nov 11, 2026
Merged

lihaojie-CMCC merged 1 commit into
mainfrom
lihaojie-CMCC-patch-1

Conversation

@lihaojie-CMCC

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

As reported in #88, a few test scenarios were missing to reach full coverage for the qa-assistant-service API.

Which issue(s) this PR fixes:

Fixes #88

Special notes for reviewers:

We have updated code/Test_definitions/qa-assistant-service.feature, adding 11 new scenarios (increasing the total from 15 to 26) to cover the Mandatory, Recommended, and Completeness suggestions from the issue.

Breakdown of added scenarios:

  • Mandatory:
    • 400 invalid x-correlator (ensuring a valid body is provided first to avoid 400 due to missing prompt).
  • Recommended:
    • 400 malformed assistantId format (using a non-UUID string).
  • Coverage Completeness:
    • Request-body strictness: Added unknown property checks at the top level and nested levels (Scenario Outline).
    • Prompt validation: Added cases for empty prompt ("") and whitespace-only prompts.
    • Response field formats: Added assertions for both 400 error fields and 200 success fields against the schema.
    • Lifecycle state validation: Added happy-path scenarios verifying that the assistant exists, the assistant is active, and the referenced knowledge base is available.

@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 31 hints | Profile: standard

View full results

@lihaojie-CMCC
lihaojie-CMCC merged commit e61d1f9 into main Nov 11, 2026
3 checks passed
@lihaojie-CMCC
lihaojie-CMCC deleted the lihaojie-CMCC-patch-1 branch November 11, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Findings in test scenarios for qa-assistant-service

1 participant