Repository navigation
fix: remove 404 from GET /network-access-devices collection - #191
Merged
clundie-CL merged 2 commits intoOct 16, 2026
Merged
Conversation
…oject#188) - Drop the Generic404 response from getNetworkAccessDevices. A collection GET has no identifier to miss; an empty result is 200 with [], as the spec's collection-responses section already states. - Align the operation's test-definition header with the remaining codes.
1 of 2 tasks
clundie-CL
marked this pull request as ready for review
October 7, 2026 12:43
clundie-CL
requested review from
benhepworth,
caubut-charter and
mayur007
as code owners
October 7, 2026 12:43
caubut-charter
previously approved these changes
Oct 16, 2026
caubut-charter
left a comment
caubut-charter
left a comment
Contributor
There was a problem hiding this comment.
Approving.
Two optional improvements: add an explicit empty-result scenario, and include the existing 400 response in the feature header’s response-code list. Neither blocks approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
GET /network-access-devicesdeclared a404response. A collection endpoint has no identifier to miss: an authorized caller with no devices gets200with an empty array, which the spec's own Collection responses section already states ("an empty collection is never signalled with404"). The other collection GETs (/reboot-requests,/trust-domains,/services) already declare no404.Changes:
code/API_definitions/network-access-devices.yaml: remove the404(Generic404) response fromgetNetworkAccessDevices. Its response set is now200, 400, 401, 403, 500, 503.code/Test_definitions/network-access-devices-getNetworkAccessDevices.feature: update the header's documented response codes. The feature has no404scenario.Which issue(s) this PR fixes:
Fixes #188
Does this PR introduce a breaking change?
Special notes for reviewers:
404stays onGET /network-access-devices/{networkAccessDeviceId}and on every reboot-request operation, where a specific ID can be missing.GET /trust-domains/{trustDomainId}/devicesalso keeps its404, since the parent Trust Domain can be missing.404is unaffected, and the API is still 0.x.mainafter the r3.1 RC, so it will be in the r3.2 initial public snapshot.redocly lint(run fromcode/) exits 0 on both specs with warnings unchanged frommain. The CAMARA release-review Spectral ruleset reports findings identical tomain.Changelog input
Additional documentation
This section can be blank.