Repository navigation
fix(validation): exempt notificationsBearerAuth-only requirements from S-042 - #526
Merged
hdamker merged 1 commit intoNov 9, 2026
Merged
Conversation
…m S-042 The receiver-side notification template in Commonalities is secured only by the notification delivery scheme and has no openId scheme by design. Refs camaraproject/Commonalities#746
Contributor
Author
|
Merged as a hot fix for camaraproject/Commonalities#746 |
This was referenced Nov 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
S-042
camara-security-openid-schemetreats any named security requirement as "secured" and then demands theopenIdscheme. The receiver-side notification template in Commonalities (artifacts/notification-templates/sample-notification.yaml) is secured only by the notification delivery schemenotificationsBearerAuthand has noopenIdscheme by design, so the Commonalities Artifacts Lint fails on every PR sincev1-rcmoved to v0.11.1 (camaraproject/Commonalities#746).A requirement that names only
notificationsBearerAuthno longer counts as secured for theopenIdtest, the same reasoning as the existing callback exemption. A provider API secured by any other scheme still fires. The FAQ entry and the ruleset changelog say so; two tests cover the receiver-side shape and a renamed bearer scheme.Which issue(s) this PR fixes:
Refs camaraproject/Commonalities#746
Special notes for reviewers:
With this ruleset all four Commonalities templates lint with zero errors, and the findings of the regression fixture branch
regression/r4.3-broken-spec-security-schemeare unchanged. The change is underlinting/**, which the Validation Regression canary's path filter does not cover; the canary is dispatched manually after merge. Patch release v0.11.2 follows, then thev1-rcmove.Changelog input
Additional documentation