Skip to content

config: raise NotImplementedError from abstract ConfigNamespace methods #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prownd wants to merge 1 commit into from
Closed

config: raise NotImplementedError from abstract ConfigNamespace methods #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions iniparse/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ConfigNamespace:
# Methods that must be implemented by subclasses

def _getitem(self, key: str) -> object:
return NotImplementedError(key)
raise NotImplementedError(key)

def __setitem__(self, key: str, value: object):
raise NotImplementedError(key, value)
Expand All @@ -32,8 +32,7 @@ def __delitem__(self, key: str) -> None:
raise NotImplementedError(key)

def __iter__(self) -> Iterable[str]:
# FIXME Raise instead return
return NotImplementedError()
raise NotImplementedError()

def _new_namespace(self, name: str) -> "ConfigNamespace":
raise NotImplementedError(name)
Expand Down
22 changes: 22 additions & 0 deletions tests/test_ini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,3 +833,25 @@ def test_option_continuation_single(self):
ip.section.option = '\n'.join(['', '', '', 'foo', '', '', ''])
ip.section.another = 'baz'
self.assertEqual(str(ip), self.s6)


class TestConfigNamespaceAbstract(unittest.TestCase):
def test_abstract_methods_raise(self):
"""
:id: 855cbd60-05d1-449f-91c0-d77a8dfa2e59
:title: Abstract ConfigNamespace methods raise NotImplementedError
:description:
Verifies that the abstract _getitem() and __iter__() methods of
ConfigNamespace raise NotImplementedError instead of returning
the exception object (which made `key in ns` always True).
:tags: Tier 3
:steps:
1. Create a bare ConfigNamespace.
2. Check membership and iterate over it.
:expectedresults:
1. Object is created.
2. NotImplementedError is raised in both cases.
"""
ns = config.ConfigNamespace()
self.assertRaises(NotImplementedError, lambda: 'key' in ns)
self.assertRaises(NotImplementedError, iter, ns)