Repository navigation
Conversation
test_compat.py imported 'test.support' only to locate the 'cfgparser.1'
data file shipped with CPython's own test suite. That package is not
installed on many systems (it is packaged separately, e.g. python3-test
on Fedora/CentOS), so the whole module failed to import:
ModuleNotFoundError: No module named 'test'
and 'python3 -m pytest' aborted during collection. Create the needed
file in a temporary directory instead, and drop python3-test from the
CI pre-test script.
Fixes: candlepin#28
zpetrace
approved these changes
Sep 30, 2026
zpetrace
left a comment
zpetrace
left a comment
Contributor
There was a problem hiding this comment.
The changes looks good, it makes sense and thanks for taking the time to change it! LGTM:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_compat.py imported 'test.support' only to locate the 'cfgparser.1' data file shipped with CPython's own test suite. That package is not installed on many systems (it is packaged separately, e.g. python3-test on Fedora/CentOS), so the whole module failed to import:
and 'python3 -m pytest' aborted during collection. Create the needed file in a temporary directory instead, and drop python3-test from the CI pre-test script.
Fixes: #28