Add i.MX93 camera support for AP1302 with shared NXP camera handler (New) - #2876
Merged
Merged
Conversation
add camera support for i.mx93
stanley31huang
added
the
ce-oem
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Add factory-routing test coverage and document the new i.MX93 scenario.
Pull request overview
Adds i.MX93 AP1302 camera support and generalizes the shared NXP i.MX camera handler.
Changes:
- Adds AP1302 and i.MX9 platform support.
- Renames the shared handler to
ImxBaseCamera. - Adds i.MX93 image and video scenarios.
File summaries
| File | Summary |
|---|---|
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/data/NXP-MIPI-Camera-TestScenario-TestSetup/imx93_mipi_camera_test_scenario_ap1302.json |
Adds i.MX93 AP1302 capture and recording configurations; provider documentation should be updated. |
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/bin/camera_imx.py |
Adds AP1302 and i.MX9 routing; focused factory tests are needed. |
Review details
Suppressed comments (1)
contrib/checkbox-ce-oem/checkbox-provider-ce-oem/data/NXP-MIPI-Camera-TestScenario-TestSetup/imx93_mipi_camera_test_scenario_ap1302.json:1
- This adds a user-facing i.MX93 scenario, but the provider's camera documentation is not updated to describe or link it. The documented platform-addition procedure in
units/camera/README.md:346-356requires a platform section, so users cannot discover the required scenario-file path from the provider docs.
{
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for the i.MX93 camera path using the AP1302 sensor in the CE OEM camera test framework.
The camera factory previously only accepted imx8m as a supported platform and used an Imx8mBaseCamera name that implied a narrower platform scope than the actual implementation. This patch updates the platform support logic to cover both imx8m and imx9 families, and renames the shared handler to a generic NXP i.MX camera base class to better reflect the common behavior.
It also adds the i.MX93 MIPI camera scenario configuration for the AP1302 sensor, covering both still-image capture and video recording at the supported resolutions and frame rates.
Resolved issues
Documentation
Tests
https://certification.canonical.com/hardware/202503-36431/submission/511688/test-results/