docs(readme): correct the test command and the Go version badge - #560
Open
0xrlawrence wants to merge 1 commit into
Open
docs(readme): correct the test command and the Go version badge#5600xrlawrence wants to merge 1 commit into
0xrlawrence wants to merge 1 commit into
Conversation
Two inaccuracies in README.md: - 'Running Tests' instructs the reader to run 'make test'. No such target exists in the Makefile; the target is 'make test/all'. Running the documented command fails outright. - The Go version badge advertises v1.21, but go.mod has required Go 1.26.0 since the toolchain bump. Documentation only; no code affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two inaccuracies in README.md that affect anyone following it.
Changes Made
make test. No such target exists in the Makefile — it ismake test/all. The documented command fails outright.go.modhas required Go 1.26.0 since the toolchain bump.Testing
Documentation only; no code affected.
Note
This touches the badge block, which #548 also edits. The changes are independent (that PR changes badge link targets, this one changes the version in the badge image URL), but may need a trivial rebase depending on merge order.
🤖 Generated with Claude Code