fix: generate the wallet directory with UTF-8 - #18
Closed
Bortlesboat wants to merge 1 commit into
Closed
Bortlesboat wants to merge 1 commit into
Bortlesboat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The directory generator now works with Python's default Windows encoding. Previously it raised
UnicodeEncodeErrorwhen writing the checkmark inWALLET_DIRECTORY.md; input and output now explicitly use UTF-8.Validation
Ran the complete generator on Python 3.12 for all eight current wallets with UTF-8 mode both enabled and disabled. Both outputs are byte-for-byte identical to the committed directory. The legacy-encoding run also passes with implicit-encoding warnings treated as errors.
The wallet application and attestation checklist does not apply to this generator fix.
Post-Deploy Monitoring & Validation
No additional operational monitoring required: this changes a local Markdown generator and preserves its current output.