Repository navigation
Prioritize usable extensions in the chat @ picker - #174
Merged
Merged
Conversation
canvascoding
marked this pull request as ready for review
October 17, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat @ picker could let catalog entries and connections needing setup obscure usable local extensions. It now loads local results first, refreshes actual connections and package requirements next, and loads catalog offers last below the usable group. Still usable recent references lead the list, and new pages preserve the focused row.
Connected refreshes cover plugins and skills as well as MCP/Composio, including a plugin-only filter. Required MCPs must match the exact template or permitted configuration. A bounded cache retains only immutable package requirements; current source rights and connection policies are checked again. Provider status observations are bounded, scoped and invalidated by the existing Composio lifecycle. Search executes no provider tools or business actions.
Validation completed:
The full production build passes for the product sources in f131930, and the compiled local app is healthy. Final browser acceptance awaits manual navigation of the old test tab out of a data: network-error page; browser policy blocks automated actions from that page. The 300 ms p95 target is not established by these checks. Positive Composio observations use controlled account-status fixtures; this is not a live provider business-action acceptance.
Implementation and validation notes:
docs/architecture/canvas-notebook/plugin-tool-gateway/chat-reference-priority-implementation.md.CodeQL alert #241 was independently reviewed and dismissed as a false positive: the SHA-256 values are private, bounded in-memory change fingerprints, not password verifiers or public credentials. The rule remains enabled; all current checks pass.
Merge note (2026-10-17): The user explicitly requested merging now with the final browser acceptance still outstanding. The browser limitation and the missing UI acceptance proof remain documented; no successful browser acceptance is claimed. All six checks for head 505f3b7 are successful, and there are no unresolved review threads.