fix: Consider codelists readonly - #177
Merged
Merged
Conversation
daogrady
changed the title
tim-sh
reviewed
Aug 24, 2026
tim-sh
left a comment
tim-sh
left a comment
Member
There was a problem hiding this comment.
Looks good.
Did you run this against a bookshop AdminService (sap.common code lists) end-to-end by any chance? So we could confirm the readonly runtime behavior against the generated GET-only output.
Also, #173 has a new comment that might get ack'd inadvertently if we close that issue merging this PR.
Contributor
Author
|
Yes: before patch ("Creates a single scan state" is present in navigation) Thanks for pointing out the comment, I can look into it. |
tim-sh
self-requested a review
August 24, 2026 13:36
tim-sh
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #173