Repository navigation
Treat a missing email subject as empty - #136
Merged
Merged
Conversation
MailCatcher returns "subject": null for emails without a Subject header, which made Email::getSubject() throw a TypeError and every subject assertion error out instead of passing or failing. Resolves: captbaritone#135
Jamesking56
approved these changes
Oct 1, 2026
Jamesking56
left a comment
Jamesking56
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed all three changed files. The null-to-empty fallback fixes issue #135 through the shared subject getter and preserves existing subjects. Unit tests pass locally (20 tests, 37 assertions), and all six CI test configurations pass.
Collaborator
|
Thanks @wazum |
|
Released in 4.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #135
MailCatcher returns
"subject": nullfor emails without aSubjectheader.Email::getSubject()is declared: string, so it threw aTypeError. As a result,seeInLastEmailSubject,dontSeeInLastEmailSubjectand their...Tovariants errored instead of acting as assertions.getSubject()now returns''for a missing subject. The constructor still acceptsnull, so nothing changes for callers.Tests
EmailTest::testMissingSubjectIsEmptyMailCatcherTest::testDontSeeInLastEmailSubjectWithoutSubject: passesMailCatcherTest::testSeeInLastEmailSubjectWithoutSubjectFails: fails as an assertion, not with aTypeErrorAll three failed with the
TypeErrorbefore the fix. I confirmed against a real MailCatcher that an email sent over SMTP without aSubjectheader comes back with"subject": null.