Skip to content

Consolidate dependency updates and temporarily make live login manual - #46

Merged
miniprow[bot] merged 2 commits into
mainfrom
fix/consolidate-dependency-prs
Nov 14, 2026
Merged

miniprow[bot] merged 2 commits into
mainfrom
fix/consolidate-dependency-prs

Conversation

@cpanato

@cpanato cpanato commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Consolidates the dependency updates from #43, #44, and #45 into one PR and temporarily makes the live token-exchange workflow manual-only.

  • Update carabiner-dev/actions to v1.3.1 at its pinned commit.
  • Update sigstore to v1.11.3 and raise the minimum Go version to 1.27 as required by that release.
  • Update golang.org/x/term to v0.48.0 and reconcile indirect dependencies and checksums with go mod tidy.
  • Keep live token exchanges available through workflow_dispatch with the existing production/development server choices. Restore PR and push triggers once tenant ownership is configured on the auth server.

The live check currently fails with HTTP 400 invalid_target because no tenant owns github/carabiner-dev/deadrop. The temporary override removes automatic live login coverage; exchange behavior continues to be covered by the Go tests.

Validation: go test -race ./..., go vet ./..., golangci-lint v2.15.0 (0 issues), actionlint, go mod tidy -diff, and git diff --check. Re-ran actionlint and git diff --check after changing the workflow triggers.

Supersedes #43, #44, and #45; the original PRs remain open pending review of this replacement.

@miniprow

miniprow Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

Details Approved by a repository administrator.

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato

cpanato commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

/override

@miniprow

miniprow Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@cpanato: you are not authorized to /override. Only users in the override.allow list may use this command.

@puerco

puerco commented Nov 14, 2026

Copy link
Copy Markdown
Member

/override

@miniprow miniprow Bot added the override/checks Overrides failing check runs, allowing merge despite failures label Nov 14, 2026
@miniprow

miniprow Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@puerco: override applied — failing check runs and failing miniprow policy checks no longer block merging this PR.

miniprow will merge this PR automatically once every other merge requirement is met. If GitHub still rejects the merge (for example, branch protection enforcing a failing check), a comment will explain why. Use /override cancel to remove the override.

@miniprow miniprow Bot added the override/policy Overrides failing miniprow policy checks, allowing merge despite policy failures label Nov 14, 2026
@cpanato cpanato changed the title Consolidate dependency updates from #43, #44, and #45 Consolidate dependency updates and temporarily make live login manual Nov 14, 2026
@miniprow miniprow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files lgtm Indicates that a PR is ready to be merged (Looks Good To Me) labels Nov 14, 2026
@miniprow
miniprow Bot merged commit eac7ebe into main Nov 14, 2026
9 checks passed
@cpanato

cpanato commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

/lgtm
/approve

@miniprow
miniprow Bot deleted the fix/consolidate-dependency-prs branch November 14, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files lgtm Indicates that a PR is ready to be merged (Looks Good To Me) override/checks Overrides failing check runs, allowing merge despite failures override/policy Overrides failing miniprow policy checks, allowing merge despite policy failures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants