chore: upgrade nodeJS and pnpm - #298
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
brunomenezes
force-pushed
the
chore/upgrade-pnpm-nodejs
branch
from
September 22, 2026 17:40
11771b3 to
5159ddb
Compare
Coverage Report for CI Build 35762197515Coverage remained the same at 66.43%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
tuler
approved these changes
Sep 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why now
Two deadlines, one of them immediate:
still run on it, so CI breaks on that date whether or not we do anything else.
supported runtime.
Since the pnpm upgrade was already required to unblock the toolchain, we also
adopted the same install-time supply-chain policy used in
rollups-explorer#475.
No application code changed. No user-facing behaviour changes, and
next.config.js/src/are untouched — the Vercel build path is unaffected.What changed
Toolchain — Node.js 22 → 24.21.0 (LTS), pnpm 10.25.0 → 11.27.1.
Supply-chain policy (
pnpm-workspace.yaml) — pnpm 11 removedonlyBuiltDependencies, so build approvals move toallowBuilds, plus:allowBuildsstrictDepBuildsblockExoticSubdepsminimumReleaseAge: 10080trustPolicy: no-downgradeCI —
checkoutv4→v7,setup-nodev4→v7,pnpm/action-setupv4→v6.1.0(v4 cannot install pnpm 11),
chromaui/actionv13.2.0→v18.9.4, andcoverallsapp/github-actionpinned off the moving@mastertag to v2.3.8.The
build.ymlworkflow is renamedDocker→CI, which is what it has alwaysactually been.
Cleanup — removed the dead root
Dockerfile(pinnednode:14, referenced ayarn.lockdeleted years ago, built nothing); pruned two build approvals forpackages that no longer run build scripts.
Notable finding
blockExoticSubdepsimmediately caught a real issue:ethereumjs-abiwas beingpulled from an unpinned git URL with no ref, meaning it resolved to whatever
that branch's HEAD happened to be at install time. It reached us eight levels
deep via
@cartesi/staking-pool → @ensdomains/ens-contracts → … → eth-sig-util.Fixed by pinning the equivalent registry release through
overridesrather thanweakening the setting. The lockfile now contains zero git or tarball sources.
Reviewer notes
minimumReleaseAgedoes not affect CI (--frozen-lockfilenever re-resolves);it applies to
pnpm add/pnpm updatelocally.corepack enable— documented in the README.Follow-up
Migrating to
pnpm/setup@v3(replacespnpm/action-setup+actions/setup-nodewith a single step) is deliberately deferred to its own PR, so a CI failure here
has one candidate cause rather than two.