You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Restrict user from changing Options.DT64_DTYPE and Options.DT64_UNIT #861
These can actually be changed via Options.set_value(), not that anyone should, but it can lead to some gnarly bugs. I put these attributes in Options because there weren't any constants at the time that weren't meant to be changed so it looked like a natural place to put them, but when writing the unit tests it became clear to me that these two values aren't "Options" in the optional sense.
I think these shouldn't be changed, so it would make more sense to move these to a new class called Constants.
Since this is Python, a user could change them anyway, but changing how the code is organized will make it more clear to future maintainers that they were meant to be calculated automatically and then remain as-is.
Activity
henrydingliu commentedon May 26, 2026
so double underscore maybe?