Skip to content

[DOCS] Fix dead links found by the link check - #1570

Merged
henrydingliu merged 1 commit into
casact:mainfrom
Abhayindia:docs/fix-dead-links-1564
Nov 10, 2026
Merged

henrydingliu merged 1 commit into
casact:mainfrom
Abhayindia:docs/fix-dead-links-1564

Conversation

@Abhayindia

Copy link
Copy Markdown
Contributor

Fixes #1564.

The monthly link check reported 24 broken links. Going through them, 5 were real and 19 were not.

Real, fixed here: the four jupyterbook.org links in comments in docs/_config.yml and docs/_toc.yml now use the /v1/ documentation, which is the version this repository builds with, and the "add a link to your repository" section now points at /v1/basics/repository.html, where that heading lives. The fifth, the nbviewer link in the sandbox workbook, was already fixed in #1561.

Not real, excluded in .github/lychee.toml: 18 are one parsing artifact. In a notebook's JSON, a URL inside a string is followed by an escaped quote, and lychee turns that backslash into a slash, so .../clrd.csv is checked as .../clrd.csv/. The raw data links (6) and the SVG DTD links (6) both come from this; the namespace links (6) are the same artifact with a # in them. The data links themselves return 200, with both master and main. The last one is a $REPO placeholder in deprecation_subissue.yml.

Checked: every new URL returns 200 and the two YAML files and the TOML config parse. I could not run lychee locally, so the excludes are untested against the real report; this pull request changes .github/lychee.toml, so the Link Check workflow runs on it and its summary will show whether any errors are left.

@github-actions

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 16.7% of exported symbols fully typed (265 / 1586)

Known Ambiguous Unknown Total
Project (head) 265 101 1220 1586

Other symbols referenced but not exported by chainladder: 24

Known Ambiguous Unknown Total
Other (head) 11 1 12 24

Symbols without documentation:

  • Functions without docstring: 326
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.59%. Comparing base (df25ff0) to head (fc238c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1570   +/-   ##
=======================================
  Coverage   94.59%   94.59%           
=======================================
  Files          98       98           
  Lines        6233     6233           
  Branches      799      799           
=======================================
  Hits         5896     5896           
  Misses        216      216           
  Partials      121      121           
Flag Coverage Δ
unittests 94.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu merged commit 8e2e53c into casact:main Nov 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Dead Links

2 participants