Repository navigation
[DOCS] Fix dead links found by the link check - #1570
Merged
Merged
Conversation
Abhayindia
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
November 10, 2026 01:44
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 98 98
Lines 6233 6233
Branches 799 799
=======================================
Hits 5896 5896
Misses 216 216
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1564.
The monthly link check reported 24 broken links. Going through them, 5 were real and 19 were not.
Real, fixed here: the four
jupyterbook.orglinks in comments indocs/_config.ymlanddocs/_toc.ymlnow use the/v1/documentation, which is the version this repository builds with, and the "add a link to your repository" section now points at/v1/basics/repository.html, where that heading lives. The fifth, the nbviewer link in the sandbox workbook, was already fixed in #1561.Not real, excluded in
.github/lychee.toml: 18 are one parsing artifact. In a notebook's JSON, a URL inside a string is followed by an escaped quote, and lychee turns that backslash into a slash, so.../clrd.csvis checked as.../clrd.csv/. The raw data links (6) and the SVG DTD links (6) both come from this; the namespace links (6) are the same artifact with a#in them. The data links themselves return 200, with bothmasterandmain. The last one is a$REPOplaceholder indeprecation_subissue.yml.Checked: every new URL returns 200 and the two YAML files and the TOML config parse. I could not run lychee locally, so the excludes are untested against the real report; this pull request changes
.github/lychee.toml, so the Link Check workflow runs on it and its summary will show whether any errors are left.