Repository navigation
[FIX] Build DevelopmentML projected valuations from an integer index #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e30648c
[FIX] Build DevelopmentML projected valuations from an integer index
scks1 25ca40c
[FIX] Find the DevelopmentML latest diagonal by valuation at every grain
scks1 f7b58cb
[TST] Pin GLM ultimates at every grain and cite Renshaw and Verrall
scks1 be30ac5
[TST] Retrigger CI after a runner download timeout
scks1 fbf1d20
[TST] Turn the leading test comments into docstrings
scks1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you fixturized the data from test_monthly_poisson_glm_matches_chainladder, we could have a stronger test that pins the actual ultimates through all the grains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The exact-pattern data is now the
exact_monthlyfixture, extended from 8 to 24 monthly origins so the yearly grains keep two origins. With 8, OYDY collapses to a single cell.test_poisson_glm_matches_chainladderruns at all ten grains and checks the GLM's chain ladder ultimates againstcl.Chainladderon the same triangle. On main it fails at seven of the ten, every grain except OQDQ, OSDS and OYDY, with NaN left intriangle_ml_and a lower total. I kepttest_projection_fills_future_cellson themonthlysample since it covers theTweedieGLMwrapper on real data. The new test fits withsolver="newton-cholesky", which converges in about ten iterations. With lbfgs atmax_iter=1000, three grains stopped at the cap with a ConvergenceWarning, and raising the cap until they converge took the file from about 3 to 6 minutes. The test filters the matmul RuntimeWarning that newton-cholesky emits, and the ultimates still match atrtol=1e-4.(This comment was written with Árbol, an AI assistant, under my direction.)