Repository navigation
[CHORE] Change all project references from chainladder-python to chainladder (#1595) - #1656
ashleyjtoth wants to merge 1 commit into
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 100 100
Lines 6460 6460
Branches 819 819
=======================================
Hits 6139 6139
Misses 203 203
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@ashleyjtoth thanks for your first PR! @casact/chainladder-maintainers i'm assuming we are not gonna change the github repo name and the associated URL, because it has a strong search presence (try searching chainladder on google). let me know if i got that wrong. |
|
@henrydingliu Just based on a quick discussion with Chat, I found out that Github automatically redirects your new URL. It may help to write announcements and blog posts about the rename to help Google link the new name with the old one and "transfer some ranking weight" to the new name. The proper thing to do if you have your own domain is a 301 redirect. |
|
@ashleyjtoth that's good to know. in that scenario, the order of operation would be
|
|
@henrydingliu Okay, so would you like this PR edited to change only the non-link references? |
|
@ashleyjtoth i meant to ask for your input. do those steps make sense? |
|
@henrydingliu Yes, I think so. If we updated all the links in the first step then links would not work until you finish renaming. It should also be okay to just rename the repo first and then change all the references, but the process you wrote above is standard for large projects with users. Avoids inconsistency as much as possible. |
Summary of Changes
Replaced "chainladder-python" with "chainladder" (in 577 instances throughout the project) and replaced "Chainladder-python" and "Chainladder-Python" with "Chainladder" (6 instances)
Related GitHub Issue(s)
Closes issue #1595
AI/LLM Usage
Sanity check that Xcode Find was showing more instanced of the name than git grep because it included more git metadata. Double checking/reading about git commands to make sure I got the workflow right.
Additional Context for Reviewers
This assumes you want every "chainladder-python" changed except in ignored files and uv.lock. The PyPI name is already Chainladder. I think that's all that can be done by someone who is not a maintainer but please let me know if I left something out or messed up!
Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist