Skip to content

[CHORE] Change all project references from chainladder-python to chainladder (#1595) - #1656

Open
ashleyjtoth wants to merge 1 commit into
casact:mainfrom
ashleyjtoth:task/drop-python-from-package-name
Open

ashleyjtoth wants to merge 1 commit into
casact:mainfrom
ashleyjtoth:task/drop-python-from-package-name

Conversation

@ashleyjtoth

Copy link
Copy Markdown

Summary of Changes

Replaced "chainladder-python" with "chainladder" (in 577 instances throughout the project) and replaced "Chainladder-python" and "Chainladder-Python" with "Chainladder" (6 instances)

Related GitHub Issue(s)

Closes issue #1595

AI/LLM Usage

Sanity check that Xcode Find was showing more instanced of the name than git grep because it included more git metadata. Double checking/reading about git commands to make sure I got the workflow right.

Additional Context for Reviewers

This assumes you want every "chainladder-python" changed except in ignored files and uv.lock. The PyPI name is already Chainladder. I think that's all that can be done by someone who is not a maintainer but please let me know if I left something out or messed up!

Submitter's Checklist

  • I have reviewed and am adhering to the standards outlined in the project Governing Doc.
  • The PR subject title summarizes the changes, with one proper prefix ([FIX], [FEAT], [DOCS], [TST], [CHORE], or [BRK]).
  • I am a human (not a bot), and this PR form is written by a human.

Reviewer's Checklist

  • The implementation addresses the associated issue(s).
  • The implementation is appropriate, maintainable, and follows ARCHITECTURE.md.
  • PR subject title has the proper prefix and the subject is appropriate.
  • Relevant issue(s) are linked.
  • AI/LLM usage is disclosed and appropriate.
  • Documentation and tests are appropriate.
  • CI tests passed, or any failures are acceptable.
  • Leave a comment with the final recommendation (e.g. approve as is, request a secondary review, or flag an area for more review).

@github-actions

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 18.1% of exported symbols fully typed (303 / 1677)

Known Ambiguous Unknown Total
Project (head) 303 96 1278 1677

Other symbols referenced but not exported by chainladder: 24

Known Ambiguous Unknown Total
Other (head) 11 1 12 24

Symbols without documentation:

  • Functions without docstring: 330
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (a59efc9) to head (f98accc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1656   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         100      100           
  Lines        6460     6460           
  Branches      819      819           
=======================================
  Hits         6139     6139           
  Misses        203      203           
  Partials      118      118           
Flag Coverage Δ
unittests 95.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu

Copy link
Copy Markdown
Member

@ashleyjtoth thanks for your first PR!

@casact/chainladder-maintainers i'm assuming we are not gonna change the github repo name and the associated URL, because it has a strong search presence (try searching chainladder on google). let me know if i got that wrong.

@ashleyjtoth

Copy link
Copy Markdown
Author

@henrydingliu Just based on a quick discussion with Chat, I found out that Github automatically redirects your new URL. It may help to write announcements and blog posts about the rename to help Google link the new name with the old one and "transfer some ranking weight" to the new name. The proper thing to do if you have your own domain is a 301 redirect.

@henrydingliu

Copy link
Copy Markdown
Member

@ashleyjtoth that's good to know. in that scenario, the order of operation would be

  1. put in PR that changes all non-link name references
  2. change repo name
  3. put in PR that changes all links

@ashleyjtoth

Copy link
Copy Markdown
Author

@henrydingliu Okay, so would you like this PR edited to change only the non-link references?

@henrydingliu

Copy link
Copy Markdown
Member

@ashleyjtoth i meant to ask for your input. do those steps make sense?

@ashleyjtoth

Copy link
Copy Markdown
Author

@henrydingliu Yes, I think so. If we updated all the links in the first step then links would not work until you finish renaming. It should also be okay to just rename the repo first and then change all the references, but the process you wrote above is standard for large projects with users. Avoids inconsistency as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants