fix: Function contract error messages are now respected at match time - #1398
Merged
TimothyJones merged 2 commits intoAug 28, 2026
Conversation
…matcher on thrown-error interactions - Co-Authored-By: Claude <noreply@anthropic.com>
… validate() - Co-Authored-By: Claude <noreply@anthropic.com>
TimothyJones
left a comment
TimothyJones
left a comment
Member
There was a problem hiding this comment.
This behaviour is actually by design, let's discuss on the linked issue. I've left a couple of comments, but no need to address them until we've determined whether it should match on messages.
| const messageResult = await matchContext.descendAndCheck( | ||
| matcher.message, | ||
| addLocation(`message`, matchContext), | ||
| 'message' in actual ? actual['message'] : undefined, |
Member
There was a problem hiding this comment.
This is redundant, you can just pass actual['message']
| actual: unknown, | ||
| ): Promise<MatchResult> => | ||
| Promise.resolve().then(() => { | ||
| Promise.resolve().then(async () => { |
Member
There was a problem hiding this comment.
Let's do this with chaining rather than by changing a 200 line function to be async. You can see how the http matcher does this, or follow the pattern used in the validate function.
At that point it might be simpler to separate out the expecting failure and expecting success into functions for readability.
TimothyJones
changed the title
TimothyJones
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #1397.
validatecheckmessagewhenmessageis present, instead of checkingerrorClassNamea second timecheckcheckmessagewhenmessageis present, instead of ignoring it