💥 Upgrade to NestJS 12 - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description of the PR
Upgrades all the dependencies of the package, the most significant ones being NestJS 12 and
nestjs-pino5.NestJS 12 requires a more recent runtime, such that the minimum supported Node.js version is now
22.12.@nestjs/terminus12 removes theHealthIndicatorbase class, which means the already deprecatedBaseHealthIndicatorServicehad to be removed as well. Health indicators should implement theHealthCheckerinterface directly, and build their results using the injectedHealthIndicatorService. The semantics of health checks also changed slightly: an error thrown by an indicator is now reported as an unexpected failure (HTTP500), while only a result returned bydown()produces an HTTP503.Finally, the
OutboxEventSendernow stops polling and waits for its ongoing operations inbeforeApplicationShutdownrather thanonApplicationShutdown. NestJS callsbeforeApplicationShutdownon every module before shutting down any of them, which ensures in-flight events are published before the resources the sender depends on are closed. This previously depended on the order in which modules happened to be imported, because the outbox, Spanner and Pub/Sub modules are all global and are therefore shut down in the reverse of that order.📋 Check list