Repository navigation
Membership files read by legume-numeric's two-column rule; version 0.8.6 - #35
Merged
Merged
Conversation
read_membership_pairs reads through read_two_field_rows: a quoted CSV label keeps its commas, cells are unquoted, #/% lines are comments, gzip reads, and a bad line is an error naming it. One warning counts rows with an empty gene or label, another CSV rows with more than two cells. membership_rows returns the same rows and counts without the warnings, for callers that sniff files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Membership files read by legume-numeric's two-column rule.
read_membership_pairsreads throughread_two_field_rows(legume-numeric 0.9.5). A tab line splits on tabs only. A line without one is CSV, so a quoted label keeps its commas (CD4,"CD4-positive, alpha-beta T cell"), which 0.8.5 cut at the comma.#and%lines are comments. A leading byte order mark is dropped. Gzipped files read like plain ones. A line that can't be read is an error naming its line number.membership_rows(path): the same rows with thegene/symbolheader dropped, plus their skip counts, without the warnings. It's for callers that sniff files, such as a file picker, or that word their own message.Version 0.8.6; legume-numeric floor 0.9.5.
Needs legume-numeric 0.9.5 on crates.io; CI cannot resolve it until then.