Repository navigation
Interactive views as detachable sessions - #36
Merged
Merged
Conversation
The --interactive views run through legume-tui: they survive a dropped connection, ctrl+alt+d detaches and ctrl+alt+s switches. New attach, sessions, kill and rename subcommands; --no-detach runs in the terminal only. - One session for every view of a command; squeeze checks for a stop between files. - kill takes the quit path: a write under way finishes first. - Log lines raised while a view is up are held and written after it. - run_screen and run_screen_with keep working for dependents, now as plain sessions; session-taking variants are added beside them.
- Log lines raised while a view is up are held and replayed by the crate's gate; without -v only errors are shown, as before. - Work before the first view is stoppable without bringing the screen up, so a kill waits for a write under way and nothing flashes. - Plain sessions, repaint rounds, help keys and session help come from the crate.
The key help reads as it did with 0.2, and what a session leaves goes to the terminal attached when it ends; tool-side workarounds for both are gone.
CI sets RUST_BACKTRACE, which the harness passed to the tool, so an error's trace pushed the error off the test screen; on macOS the harness also lost the terminal once the program exited. Both are fixed in the crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--interactiveviews now run through legume-tui, as the other legume tools' screens do: they survive a dropped connection and can be left and resumed.attach,sessions,kill,renamesubcommands;--no-detach(with-i) runs in the terminal only.killtakes the quit path: a write under way finishes first; work before the first view is stoppable without bringing the screen up.-vonly errors show, as before.run_screenandrun_screen_withkeep working for dependents (faba), now as plain sessions; session-taking variants sit beside them.tuifeature, without its graphics.Tests drive the real binary through pseudo-terminals.