Repository navigation
legume-mcp 0.4; a name a running job holds is skipped; version 0.10.2 - #41
Merged
Merged
Conversation
An output data-beans names itself (in today's results folder) skips any name a running job writes, however spelled, through legume-mcp's Call::ensure_free, as well as the ones data-beans' own claims hold. A name the agent gives is still refused while a job writes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
"0.3"to"0.4", for both the dependency and the dev-dependency. With 0.10.1, a tool already on legume-mcp 0.4 carried two copies of it.Call::ensure_free, on top of the claims data-beans already keeps. A name the agent gives is still refused while a job writes it, both byrun_making/spawn_joband by the claim.Checks
cargo fmt --checkandcargo clippy --all-targets --features simare clean.cargo test --features simpasses, with legume-mcp 0.4.0 and legume-tui 0.3.14.tests/detach_session.rsfailed 0 of 10 runs, and 0 of 15 on legume-tui 0.3.13. Earlier, one test (a_kill_before_the_explorer_lets_its_output_file_finish) failed once while another crate was building at the same time. It waits a fixed 1 s, so heavy load can trip it.ensure_freecheck where a name is picked.