Repository navigation
Merged
Conversation
…es never overwrite (0.16.7) faba pwm opens the sequence logo full screen unless --batch-process (or there is no terminal), takes a faba output directory or run record for its site table and recorded genome, and with no sites opens the file picker. Saved figures never replace a file; the picker's key hints take three lines.
The view is the default; --batch-process is the only switch.
In the view, with no -f and no recorded genome found here, a picker lists FASTA files; Tab downloads one from GENCODE or Ensembl into ~/faba_refs, as faba run does, starting on the source whose chromosome names match the sites. The download pop-ups now live beside the download code, shared by both.
apa_components.parquet gains a strand column (the UTR's). The site reader takes it, so pwm reverse-complements minus-strand APA sites as it does m6A and A-to-I ones; a table written before has none, read as forward with a warning to rerun faba apa.
The pwm genome picker becomes a reference picker for a genome or an annotation. In the pileup browser, with no --gtf and no recorded GFF on this machine, it lists GTF/GFF files; Tab downloads a GENCODE or Ensembl reference into ~/faba_refs. Esc browses on without gene models.
- Enter opens or chooses and never quits (pileup, metagene, pwm quit on it). - Esc goes back one level: pileup's browser returns to its gene list; a view with nothing above it quits; q quits. - Ctrl-C asks first wherever q does: faba run (now also when any setting changed, not only with BAMs picked) and qc with changed thresholds. - Ctrl+R submits any open line: save names, pileup's search, qc's typed value, the gene list, the reference picker. - Downloads: s stops, Esc hides (Tab shows it again in the picker), the folder is named first, and the pop-up lists its keys. - metagene's + is finer and - coarser, as pileup's zoom; 0 fits. - m/M switch modality in pileup as in qc; mirror moves to v, the previous site to N, pwm's bits/frequency to b, qc's annotation browser to a. - R asks before resetting every flag; Space on a folder asks before dropping marked files; Enter on a file only says Space marks it. - The busy spinner says it cannot stop halfway when a key is pressed. - Footers wrap onto more lines at any width (tui::wrap_help), keeping each key with what it does; tests check every key shows at 80 (or 60) columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
faba pwmshows the sequence logo full screen unless--batch-process(alias--batch-mode) is given, or there is no terminal.-I/--interactiveis gone from pwm, pileup and metagene: the view is the default, so--batch-processis the only switch. Old command lines with-Inow fail to parse.faba pwm out/reads the folder's site table of--modality(m6A, else A-to-I) against its recorded genome; a run record in it works too.--source referencethey must record the same genome, or--genomenames one; this is checked before any reading.-fand no recorded genome found on this machine, a picker lists FASTA files; Tab downloads one from GENCODE or Ensembl into~/faba_refs/, asfaba rundoes, starting on the source whose chromosome names match the sites.--batch-processstill stops with the error.--source referencereads the FASTA across threads, a reader per chunk of sites (same output, byte for byte, on the chr19 test set).apa_components.parquetgains astrandcolumn (the UTR's), and the site reader uses it, so pwm reverse-complements minus-strand APA sites as it does m6A and A-to-I ones. Tables written before have none: read as forward, with a warning to rerunfaba apa..bam,.cramand.samarguments are reads, the rest sites, sofaba pwm -s sites.parquet sample.bam --source readsworks as before. BAMs given without--source readsare named in a warning.-ois optional. With--batch-processand no-o, the PWM goes to{sites}.pwm.tsvin the current folder; in the view it is written only when-ois given.Saved figures never overwrite
The save prompt every figure view shares (pileup, metagene, pwm) now offers a name no save has used yet (
pwm_logo,pwm_logo_2, …). Typing a name whose.pdfor.pngexists keeps the prompt open with the next free one and says why.The picker's key hints
They no longer get cut off: three lines (moving, marking, finishing), with the list sized to leave room for them.
One set of key rules
An audit of every view's keys, applied:
qdoes (faba runsetup, now on any change;qcwith changed thresholds).sstops, Esc hides, the folder is named first, and the pop-up lists its keys, infaba runand the reference picker alike.+/-finer/coarser in metagene as in pileup;m/Mmodality in pileup as in qc (mirror →v, previous site →N); pwm's bits/frequency →b; qc's annotation browserg→a(gis pileup's gene list).R(reset every flag); Space on a folder with files marked.tui::wrap_helpwraps them onto more lines at any width, keeping each key with its description; tests check every footer at 80 (60) columns.docs/profiling-methods.md§7.Shared pieces
crate::tui::batch: "batch, or no terminal" in one place, used by pileup, metagene and pwm. metagene now also writes its TSV when there is no terminal, instead of computing and dropping it.output_dir: site-table resolution, the default output name and the view title, shared by metagene and pwm.pipeline::tui::fetch), sofaba runandpwmdraw the same ones; the hint names whose chromosome names it matched (your BAMs, or your sites).is_fastajoinsis_annotationin the shared browser.when_terminalis gone; its warning named the retired--interactive.Checks
cargo test: all pass butpipeline::tui::tests::a_folder_with_files_is_refused_as_the_output, which fails onmaintoo.cargo clippy --all-targets -D warningsis clean, with and without--features hdf5.cargo fmtis applied.