Repository navigation
Saved figures take their view's shape; drag and wheel pan pileup (0.16.9) - #22
Merged
Merged
Conversation
…6.9) - A figure saved from pileup (and each gene of a stack), metagene or pwm is sized from the area its view takes on screen, 6 x 12 points a cell (figure::page), so it keeps the view's aspect and its text sits about as large against the plots as the terminal's does. - In pileup, a press on the bars and a release elsewhere pans the window as if grabbed (a release in place is a click); the wheel and sideways swipes pan a tenth of the view a notch. In a stack, on the gene under the pointer.
- A drag or wheel notch pans by the window's span a column, as far as the pointer, not the rounded-up bases of a bar; a notch at an end of the span changes nothing and redraws nothing. - Only a press on the plots' bars grabs (not the header, genes or footer); any button clicks, as before; a press outside every gene of a stack lets go of a grab whose release was lost. - A saved logo keeps its letters 8 to 40 points wide whatever the terminal. - figure::page takes each view's minimum size; figure::svg_size reads a figure's size for tiling and tests alike.
…without let_go - PileupView::bar_at serves click_at and over_bars alike; plot_count replaces three copies of the plots-not-genes count. - A press outside every gene of a stack goes to the one with the keys, whose own press handling lets go of a grab; let_go is gone. - pwm's fallback page uses the same margins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
figure::page), so it keeps the view's aspect ratio and its 8–12-point text sits about as large against the plots as the terminal's text does. In a stack each gene keeps its pane's shape, so side by side and grid saves look as they do on screen. (A 160 × 45 terminal with two genes side by side saves as 960 × 516 pt.) Before a view is drawn, the old fixed sizes apply. qc's figures are unchanged: they are also written in batch, with no screen to follow.Review fixes
figure::pagetakes each view's minimum;figure::svg_sizeis shared by tiling and the tests; one bar-at-column test and one plot count in pileup.Checks
cargo test: all pass butpipeline::tui::tests::a_folder_with_files_is_refused_as_the_output, which fails only on this machine (it passes in CI).cargo clippy --all-targets -D warningsis clean, with and without--features hdf5.cargo fmtis applied.