Skip to content

Ship the account snapshot reader in the Mac app - #755

Merged
shiny-code-app[bot] merged 2 commits into
mainfrom
work/cp-752-snapshot-reader
Oct 3, 2026
Merged

shiny-code-app[bot] merged 2 commits into
mainfrom
work/cp-752-snapshot-reader

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

The Supervisor currently depends on a separately compiled account snapshot reader that can drift from the installed app. The Mac app now exposes --account-snapshot on its own executable, so the reader updates with every app build and uses the app's existing sandbox, App Group entitlement and signing profile.

The mode runs before SwiftUI constructs the app delegate or provider services. It shares AgentAccountSnapshotCommand with the existing SwiftPM tool, retaining schema, stdout formatting, privacy-safe errors and exit statuses. Documentation gives the stable installed command and command-array migration; the developer tool remains supported.

Validation: the full commit gate passed (1,205 Swift tests), including fixture output parity, unchanged storage, bounded private errors, help/argument handling and existing utility routing. The native Xcode app build also passed with LaunchServices registration disabled; artifact inspection confirms the reader is compiled into the app executable. Anthropic Claude Opus 5.5 reviewed the change: one low help-text finding was fixed; no correctness or privacy findings. Final-head verification and JetBrains evidence will be recorded below.

The canonical signed Production app passed its read-only baseline and is preserved. No release, publish, tag, install or production mutation. Signed execution of the new mode is not yet validated: the installed app predates this change. After a separately authorized install, verify the signed command, migrate the private launcher command and remove the capacity doc's manual rebuild instructions. The issue stays open for that installed-runtime finish line.

Refs #752

@shiny-code-app

shiny-code-app Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Cross-provider review for final head a9eb9ba:

  • Anthropic Claude Opus 5.5 reviewed 1c46d69. The low help-text finding was reproduced by the shared command: it named only the developer tool. Fixed in a9eb9ba by including the installed app invocation, with a behavioral help check. No correctness, privacy or normal-startup finding.
  • Anthropic Claude Fable 5.1 was the model actually reported by the final review of a9eb9ba; no blocking findings. Its argument-position note is accounted for: the supported command grammar starts with --account-snapshot, as documented and tested. An environment prefix belongs outside the executable's argv; no supported invocation prepends an app option. Searching for the flag anywhere would change that grammar without a demonstrated caller need. The default-root construction predates this change and still resolves to the app's entitled group; the remaining first-help-line wording is cosmetic because the same output now includes the installed command.
  • Signed-runtime proof remains unperformed, not refuted: the canonical Production app predates this mode and this brief prohibits release/install/production changes. The issue will retain signed verification and launcher migration for the next authorized install.

Final commit gate: passed, 1,205 Swift tests and the configured fast-local Python lane. Native Xcode app build: passed; artifact inspection confirms the compiled reader and expected executable name. No app build output was launched. Existing Production runtime passed the read-only baseline and is preserved.

@shiny-code-app

shiny-code-app Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Final-head JetBrains inspection: GREEN, changed_files, exact linked worktree, PyCharm 2026.2.3 run 543; zero findings, fresh result, lifecycle cleanup closed and no worktree mutation. This is the configured scope. Broad practical compilation/test coverage comes from the full commit gate and native Xcode build; no claim of signed-runtime acceptance.

Repository metadata checked: the existing docs.agentAccountSnapshot route already points to the updated contract. No validation command, important workflow, ownership boundary or inspection policy changed, so .github/github.json remains current.

@shiny-code-app
shiny-code-app Bot merged commit b459894 into main Oct 3, 2026
4 checks passed
@shiny-code-app
shiny-code-app Bot deleted the work/cp-752-snapshot-reader branch October 3, 2026 20:48
@shiny-code-app

shiny-code-app Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Normal bot merge confirmed at b459894 after all four final-head checks passed. Generic GitHub metadata still said BLOCKED; the normal merge endpoint accepted the operation under existing protections. No override, rule change or identity switch was used. Remote task branch deleted; primary main fast-forwarded cleanly to the exact landing.

Exact-landing CI and CodeQL are being watched. Signed installation/launcher migration remain on context-panel#752; no release is dispatched. Existing installed Production app remains unchanged.

@shiny-code-app

shiny-code-app Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Source closeout: context-panel#755 merged with a normal two-parent commit b459894. Final-head checks passed 4/4, and exact-landing CI and CodeQL passed; CodeQL reports zero results. Full commit gate: 1,205 Swift tests plus the configured fast Python lane; native Xcode build passed. Changed-file JetBrains run 543 was GREEN, fresh and cleaned up. Anthropic Claude Opus 5.5 and Claude Fable 5.1 reviews are accounted for above. No additional host-review lifecycle was surfaced for a9eb9ba before this closeout.

context-panel#752 remains open with plan:waiting, an updated Current Status and released claim. Its installed-runtime finish line still needs the next separately authorized signed install, a direct canonical command check, private launcher migration and capacity-doc rebuild-step removal. The installed Production app was preserved: the post-merge runtime receipt fails only the source-fingerprint comparison because that app predates this code; all other canonical runtime checks pass. No release, deployment, publish, tag or install occurred.

Primary main is clean at the landing; the remote task branch is gone. Task worktree work/cp-752-snapshot-reader stays clean and locked with CP-752-D1 after SDK-aware retirement failed; the occurrence and fresh successful SDK preview are recorded in shiny-infra-ops#385. No force removal, SDK/lease edit, extra apply or IDE restart. Generated Xcode project scratch was removed; compiled intermediate bundles were never launched and LaunchServices registration was disabled. Private source acceptance/retirement receipts stay outside the checkout until the diagnostic recovery is adopted and supported retirement succeeds. No Director decision is open for this run. This repository has no DIRECTION.md; the Director's overall direction applies.

Love: one shared read-only reader updates with the app, with no new signing target. Do not love: signed execution remains unqualified and the cleanup helper keeps the task checkout. Safe to exit: yes (remaining work is explicitly parked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant