Clarify release test fixture types and helper signatures - #756
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release behavioral tests had untyped helpers and methods whose signatures implied test-case state they never used. Add test return annotations and script-module types, make 18 independent helpers static, annotate the draft-lookup stub, and remove a redundant regex escape. Preserve all 115 tests and their assertions.
Retain explicit fixture defaults, API-override parameters, literal indentation regexes and Apple plist DTD identifiers for the reasons recorded on #749. No source-text test, suppression, profile, workflow, release script or product behavior is added or changed.
Validation: 115 release tests passed; routine Python lane and full commit gate passed, including Swift build and 1,205 Swift tests. The initial local attempt caught a missed static-helper parameter removal (corrected) and a missing cryptography dependency (supplied through uv). Anthropic claude-fable-5-1 reviewed exact commit 1cb2797 and found no defects; its review covered the helper bodies, calling signatures, regex and retained dispositions.
JetBrains exact-file inspection: UNKNOWN/project_open_blocked before native analysis, retry=false. No fresh finding count or GREEN claim. Continuing under the trial brief's explicit IDE exception. jetbrains-inspection-api#433 owns the opening failure. Exact pending lease and locked worktree are preserved unless supported cleanup proves safe retirement; the scoped dry-run timed out on lifecycle contention with no mutation. Broad IDE inspection is not run while the exact-file route is blocked.
Docs and .github/github.json checked: helper-only test cleanup changes no command, validation gate, workflow or ownership rule. No app/runtime validation is needed for this surface. No release dispatch, publication, tag or installed-runtime mutation.
Refs #749