Skip to content

Remove unused reset advice wording and correct widget documentation - #818

Merged
shiny-code-app[bot] merged 2 commits into
mainfrom
work/cp-814-d1
Oct 11, 2026
Merged

shiny-code-app[bot] merged 2 commits into
mainfrom
work/cp-814-d1

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Two unused reset-advice properties repeated wording from the shared assessment, and the design doc claimed the window widget displayed that wording. Remove compactActionText, glanceActionText and their now-unused formatter. Remove only their test assertions; keep the state, advisory-language and widget behavior/render coverage.

The design doc now describes the unchanged token: account, credit count, expiry deadline and a warning tone for a recommended reset. It also describes neutral account counts and the fit ladder's retained deadline accurately.

Validation: scripts/commit-gate.sh passed, including 1,261 Swift tests and the required Python lane. Caller checks and diff review confirmed that no product caller used either removed property. This routine removal changes no product behavior or cross-repository contract; the shared model-review policy uses executable tests as its review.

Client test notes: nothing for the Client to test; user-visible behavior is unchanged. The canonical signed Production runtime is preserved. Its app, widget, URL handler and refresh agent resolve under /Applications/Context Panel.app, but its older fingerprint fails the exact-source baseline; installed-runtime readiness is not claimed.

Refs #814

CP-814-D1: Supervisor owns merge-train routing. Stop at the reviewed, green current-head handoff; do not enqueue, merge, install or release.

JetBrains changed-file inspection: UNKNOWN / scope_semantic_coverage_missing; configured PyCharm has no Swift semantic coverage. Helper-owned project closed, with no tracked/untracked mutation. Continuing under the brief's explicit IDE-UNKNOWN allowance; this is not an inspection-clean claim. Broader PyCharm inspection cannot fix that language coverage gap. Metadata routes and gates are unchanged; .github/github.json remains current for this scope.

After main advanced, the supported GitHub branch update produced a5c397283c9e8f1a7428f30aeb9a326911eb6f09. The complete commit gate passed again on that integrated head with 1,268 Swift tests and the required Python lane. The three task files are byte-identical to the inspected and reviewed ad3dbca; the PR still changes only those three files.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

CP-814-D1: source implementation complete; CI handoff to the Supervisor after the 12:19 AM ET wall-clock deadline.

At a5c397283c9e8f1a7428f30aeb9a326911eb6f09, the fresh check read shows macos-release successful, swift-tests and Analyze Swift queued, no failures, and two unfinished workflow runs. The matching self-hosted runner was online and busy at the last runner read; neither queued job had a runner assigned. No workflow, test, runner or policy was changed to bypass this wait. This PR is not yet Ready for the merge train.

Supervisor next action: resume babysit-pr on #818, handle current-head CI/review feedback, then post Ready for the merge train only after the complete current-head gate passes and route the train. Do not enqueue or merge from this incomplete-CI receipt. There is no Client test action or Director decision for this removal, and no owner-review label.

The complete local commit gate passed on the integrated head: 1,268 Swift tests and the required Python lane. Caller/diff review confirms that only tests consumed the deleted properties; the behavior tests remain. Changed-file JetBrains assessment is UNKNOWN/scope_semantic_coverage_missing because configured PyCharm lacks Swift semantics; its owned project closed with no worktree mutation. The touched files are identical to that assessment. Continue under the brief's IDE-UNKNOWN allowance without an inspection-clean claim. Product behavior/UI is unchanged; model-review policy uses the executable tests as review for this routine removal. Issue and PR full-history comment radar are clear as of this handoff. Background review: not yet observable for this head; a post-turn review may still start.

Retain the clean pushed work/cp-814-d1 checkout and ignored build/IDE state under Supervisor custody until landing or closure and acceptance. Retain the task-evidence group (gate logs, inspection receipt, PR/check/watch receipts and drafts) for acceptance; the Supervisor disposes of it when no longer needed. Retire the task checkout with dev-worktree retire /Volumes/Developer-Artifacts/worktrees/context-panel/cp-814-d1 after landing/closure and preservation checks. The primary checkout is unchanged; the older canonical signed Production app is preserved. No merge, enqueue label, install or release occurred. After landing, reconcile #814 and any issues it unblocks.

The execution watcher and all owned validation/diagnostic processes are stopped. #814 stays plan:active because the next actor is the Supervisor; the CI gate remains explicitly pending.

@shiny-code-app

Copy link
Copy Markdown
Contributor Author

Ready for the merge train

Head: a5c3972. CP-FT-D1's 1:10 AM ET current-head watch confirms all six checks passed, zero failures/pending checks, zero unfinished workflows and complete head-matching check evidence. Clean Trusted CodeQL Temp is now terminal green. Review threads are available and empty; fresh full-history external-comment radar is clear. Existing executable-test review and local commit-gate evidence remain recorded in this PR; no source revision changed during follow-through.

GitHub reports MERGEABLE / BLOCKED; Supervisor owns authoritative train admission and routing. Client test notes explicitly say nothing to test because user-visible behavior is unchanged. No owner-review label or GitHub Client-review request was observed. The optional scoped private Client-feedback reader returned 403, so private feedback was not verified and this handoff does not claim Client acceptance; retain that read limitation if service admission requires it. Live Launchplane policy confirms repository enrollment.

The prior JetBrains UNKNOWN / scope_semantic_coverage_missing remains unchanged; no IDE-clean or installed-runtime readiness is claimed. #814 stays active for Supervisor routing and post-landing reconciliation. The source checkout/evidence remain with their existing handoff until landing/closure. No source/branch update, enqueue label, merge, release, install or device action performed. This Ready marker ends CP-FT-D1's #818 watch as instructed; no unattended continuation.

@shiny-code-app shiny-code-app Bot added the ready-to-merge Every Code PR is ready for repository owner merge review label Oct 11, 2026
shiny-code-app Bot added a commit that referenced this pull request Oct 11, 2026
@shiny-code-app
shiny-code-app Bot merged commit 9399a04 into main Oct 11, 2026
6 checks passed
@shiny-code-app
shiny-code-app Bot deleted the work/cp-814-d1 branch October 11, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Every Code PR is ready for repository owner merge review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants