Skip to content

Publish only completed merge-train candidates to CI - #2523

Merged
cbusillo merged 3 commits into
mainfrom
work/issue2384-candidate-ci
Sep 27, 2026
Merged

cbusillo merged 3 commits into
mainfrom
work/issue2384-candidate-ci

Conversation

@shiny-code-app

@shiny-code-app shiny-code-app Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

A multi-PR train currently publishes its base and intermediate merges to the checked train branch. In the real two-entry batch from September 25, that started three CI runs, including an intermediate run that scheduled heavy jobs before cancellation.

Build on a deterministic launchplane/construct/** ref, then publish the existing canonical candidate ref only after every entry's commit and tree have been verified. Required workflows continue to check the final SHA. Publication readback fails closed; construction cleanup failures are reported without replacing an already verified candidate. Failed construction retains its ref for diagnosis and retry, with its locator in native checkpoints and failure responses.

Refs #2384. Integrated with #2494's delivered protected batch-PR implementation at 42b8e589. The generated batch PR continues to use only the final canonical candidate SHA.

Validation on integrated head cbeaa9bd: all 3,629 local unittest targets and 249 focused tests pass; whole-repository Ruff, formatting, and mypy pass. Exact-worktree JetBrains changed-file inspection is GREEN with zero findings, successful cleanup, and no worktree mutation. Anthropic claude-opus-5-5 completed planning, implementation, follow-up, and integration reviews with no required fixes remaining. GitHub CI, Security, and CodeQL are complete: 27 checks succeeded and six fork-only checks were skipped, with zero failed or pending checks. A prior Google attempt was unavailable because its CLI denied a command; no personal settings changed.

The existing crash window between publication and result persistence can still require rebuilding and rechecking. Failed-build or failed-cleanup construction refs remain recovery evidence; no garbage collector or new record lifecycle was added. Target repositories must exclude construction refs from required-workflow triggers and allow their creation. Read-only checks confirmed this repository's workflows and branch protections meet those prerequisites.

Delivered through the native train at af13626023b4937ee3dda0b2c6249186383aca33. Post-merge CI, Security, CodeQL, and Launchplane deployment succeeded; the deployed smoke artifact verifies the exact image, health, and database compatibility. #2384 remains open for the next real multi-PR build on the deployed implementation. This change's own delivery used the previous builder and is not that runtime proof. CM delivery remains held under tenant #91.

@shiny-code-app
shiny-code-app Bot marked this pull request as ready for review September 27, 2026 16:02
@shiny-code-app shiny-code-app Bot added the ready-to-merge Every Code PR is ready for repository owner merge review label Sep 27, 2026
cbusillo added a commit that referenced this pull request Sep 27, 2026
@cbusillo
cbusillo merged commit af13626 into main Sep 27, 2026
33 checks passed
@cbusillo
cbusillo deleted the work/issue2384-candidate-ci branch September 27, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Every Code PR is ready for repository owner merge review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants