Delete retired approval detection and manager routes - #2530
Merged
Merged
Conversation
cbusillo
added a commit
that referenced
this pull request
Sep 27, 2026
…9faaa6c3a26ec2a: merge PR #2530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2525.
Retired approval services were still imported by live Launchplane paths. This removes the change-impact classifier, Product Owner policy service, manager approval commands/projection, and their HTTP routes. Merge admission now uses an independent Git evidence reader, while the configured signed webhook transport continues to capture trusted-maintenance evidence.
New engineering decisions use the first two configured independent review slots without consulting path-based approval policies. Historical record contracts and digests remain readable, and current product Owner/release review remains covered by regression tests. Public API artifacts and operational docs reflect the removed routes. The diff is mostly deletion, mechanical import moves, and generated schema changes; keeping the callers together avoids an intermediate broken service.
Validation at
a8aa8b0013ad9596b3e0f628192e3fe2ff20daf6:claude-opus-5-5reviewed both the deletion and the final cleanup delta; neither review found an actionable correctness or contract regression.execution_not_proven, and whole-project attempts timed out; no whole-project clean result is claimed. The owner's decision in Triage IDE diagnostics in existing Launchplane files #2463 ended baseline cleanup, so it is not reopened here. Full private captures and location triage were copied into an owner-only local archive and hash-verified before retiring the completed task worktree.Background Review: not yet observable for
a8aa8b0013ad9596b3e0f628192e3fe2ff20daf6as of 2026-09-27 18:56 UTC; a post-turn review may still start. The PR has no unanswered external comments. Launchplane landed this PR atde7f3abb2b8a63ddb465e59e239f86b4ba8db3c1. Post-merge CI, Security, CodeQL, and deployment all passed. Deployed smoke verified the matching image, healthy service, compatible database revision, and representative native routes. Local main is clean at the landing SHA.Compatibility: existing database rows and immutable digests are preserved. New schema-version-2 engineering decisions require a compatible reader; a rollback image that only understands version 1 must not be assumed able to read newly written decisions. Runtime grant and credential contraction is outside this code deletion. The CM delivery hold remains in force.
Owner test notes
Nothing for the site Owner to test. This is control-plane retirement; current preview/release review and release blocking are exercised by automated tests.
Closeout (2026-09-27 19:47 UTC): #2525 is complete. The task worktree, merged local branch, and 72 task scratch files are removed; 175 retained evidence/configuration files were verified before removal. The remote task branch was already absent. Local main remains clean at the deployed landing SHA; other worktrees, refs, stashes, and shared caches were preserved. Background Review remains not yet observable for source head
a8aa8b0013ad9596b3e0f628192e3fe2ff20daf6at this observation; a post-turn review may still start.Final IDE cleanup: the obsolete task-specific PyCharm interpreter reference was removed through the IDE UI. Other interpreter entries were preserved, and the active project retained its original interpreter.