Allow reviewed recovery for legacy final-size jobs - #643
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bluey’s August encode predates production approval contracts, so the final-size recovery guard could not compare its newly approved 275 MB/45m sample with the failed 300 MB/45m target and blocked every supported queue path.
Allow legacy single-item recovery only when the old failure records a target, the manifest records the item duration, and those values prove the newly approved size goal changed. Missing or ambiguous evidence still fails closed.
Validation:
bash scripts/pre-commit-check.sh(1,994 backend tests, 462 frontend tests, CLI/frontend/build/route smoke)uv run --with ruff ruff check mediaforce/web/runtime/folder_actions.py tests/test_legacy_final_size_recovery.py