Avoid password-change notices on unchanged startup - #113
Merged
Merged
Conversation
Contributor
Author
|
Final head The active Launchplane policy currently enrolls launchplane, codex-skills and the CM website only; odoo-devkit is not a train target. Native dry-run returned |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary runtime restarts rewrote the configured administrator password even when it already matched. Odoo 19 sends a password-change security email on every password write, so enabling SMTP exposed repeated notices and bounces from preview refreshes.
Verify the password through Odoo's credential API before writing it. Unchanged credentials remain untouched; a configured rotation retains Odoo's normal write and notification path. Unexpected verification errors stop startup. Preserve quotes and backslashes when embedding the configured credential in the startup shell. Replaces the old script-text assertion with behavioral repeat-startup, rotation, missing-user and failure coverage. Refs #112.
Validation: all 268 tests passed (one skipped), repository Ruff checks/formatting, runtime Python lock, package build and CLI smoke passed. Final changed-file JetBrains assessment is RED with 13 existing findings outside changed lines; whole-project assessment reported 293 repository diagnostics. Runtime-only dependency/SQL metadata and older test/style findings remain tracked by #111. The final assessment used the exact worktree interpreter and verified project cleanup; incidental IDE changes were preserved separately and removed from this PR.
Anthropic
claude-opus-5-5independently reviewed both revisions against the pinned Odoo 19 source. Its first review found the pre-existing quoted-password failure; that failure was reproduced, fixed, and covered by the repeat-startup test. Final review reported no findings. No notification suppression or authentication policy change was added.Owner test notes
Nothing for the site Owner to test in this shared-runtime PR. The CM consumer pin and testing rollout will be separate from the already accepted website change.