Accept a source commit a branch or tag contains - #140
Merged
Merged
Conversation
Publish required each source commit to be a ref tip, so every merge to devkit main broke the next artifact build of every tenant pinned to the previous tip. A commit that is not a tip now passes when a branch or tag of its origin contains it, found by fetching only commit history. The commit itself is never fetched by id, so a fork-network commit still fails. Fixes #139
Initialize the verification repository with an empty template and disable lazy fetching, so neither an inherited template nor a missing-object lookup can supply a commit. for-each-ref --contains already rejects an unknown commit, so the separate existence probe is gone. From an OpenAI gpt-6.1-sol review.
shiny-code-app Bot
added a commit
that referenced
this pull request
Sep 30, 2026
…54677b25352292c: merge PR #140
shiny-code-app Bot
added a commit
that referenced
this pull request
Sep 30, 2026
…5174822a49e6198: merge PR #140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every merge to devkit
mainbroke the next artifact build of every site pinned to the previousmaintip. The publish check required each source commit to be a ref tip (git ls-remote). After #137 movedmain, cm-website's pin74f4cf7, still an ancestor ofmain, was refused, and cm-website#108'sbuildfailed.What changed
remote_branch_or_tag_contains_commitdoes the following:--filter=tree:0) for the origin's branches and tags into a temporary bare repository, created with an empty template and with lazy fetching disabled;docs/tooling/artifact-inputs.mdsays what "published in its origin" now means.Review
OpenAI gpt-6.1-sol found the reachability rule sound under the fork threat model. Two findings are applied:
--template=;GIT_NO_LAZY_FETCH=1is set.Declined: a Git version check for
--filter=tree:0. Every supported Git has had it since 2.20, and a failed fetch already stops with Git's error.Verification
mainand refuses a commit whose branch was deleted.74f4cf7is accepted againstcbusillo/odoo-devkit, and an unknown commit is refused.Fixes #139