feat(ci): add notarized release workflow - #16
Open
cchandurkar wants to merge 12 commits into
Open
cchandurkar wants to merge 12 commits into
cchandurkar wants to merge 12 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/workflows/release.yml: on tag push (v*.*.*) or manual dispatch, builds installers on macOS/Windows/Linux vianpm run release, uploads them as workflow artifacts, then apublishjob creates/updates the GitHub Release for that tag withgh release create/gh release upload.notarytool, gated on 6 repo secrets (MAC_CERTIFICATE_P12_BASE64,MAC_CERTIFICATE_PASSWORD,APPLE_API_KEY_BASE64,APPLE_API_KEY_ID,APPLE_API_ISSUER,APPLE_TEAM_ID), scoped so they cannot leak into the Windows/Linux legs.Why
Follow-up to the PR review discussion on adding notarized release artifacts.
Notes
electron-builder.jsonchanges needed —package:releasealready passes-c.mac.notarize=trueas a CLI override, so localnpm run packagestays fast/unsigned.workflow_dispatch, so merging has no effect onci.yml's existing push/PR triggers.