Formatted more masterfiles subdirectories with cfengine format#3179
Merged
Conversation
olehermanse
commented
Jun 25, 2026
olehermanse
commented
Member
- cfengine format ./cfe_internal/
- cfengine format ./lib/
- cfengine format ./tests/acceptance/30_custom_promise_types/
- cfengine format ./tests/acceptance/lib/
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
Member
Author
|
@cf-bottom jenkins, please |
Member
Author
|
@nickanderson @craigcomstock this one basically includes the last directories except packages tests (which have very large policy files). |
larsewi
reviewed
Jun 25, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
One way to preserve inline comment could be to have it as a different token. For example having it resolve to an inline_comment if it's not preceded by only whitespace.
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14018/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14018/ |
larsewi
approved these changes
Jun 25, 2026
Member
Author
|
Test failures / flakes look unrelated. Known issues. |
Member
Author
|
Backports: #3193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.