Skip to content

Fix CI publishing with a verified Maven toolchain - #46

Merged
ShawnChen-Sirius merged 1 commit into
mainfrom
codex/snapshot-maven-toolchain
Nov 18, 2026
Merged

ShawnChen-Sirius merged 1 commit into
mainfrom
codex/snapshot-maven-toolchain

Conversation

@ShawnChen-Sirius

@ShawnChen-Sirius ShawnChen-Sirius commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Bootstrap Apache Maven 3.9.16 from the official archived distribution and verify a pinned SHA-512 before extraction or execution.
  • Set up Maven explicitly in all Maven-using build jobs and release preflight, staging, and deployment jobs; do not depend on runner-preinstalled Maven.
  • Add five offline installer tests and update the release-readiness checkpoint with the snapshot verification evidence and remaining gates.

Why

Snapshot run 44272921635 failed for two distinct reasons: attempt 1 reached Central but received HTTP 502 during transfer; attempt 2 stopped before Maven ran because its ubuntu-latest ARM64 runner had no mvn executable (exit 127). This PR fixes the missing-toolchain failure only; it does not claim to resolve the earlier Central HTTP 502.

Validation

  • 12 tooling tests passed (7 consumer-POM tests and 5 Maven installer tests).
  • Installer shellcheck, bash syntax check, git diff --check, and workflow actionlint structure checks passed; full workflow ShellCheck still has pre-existing unrelated style warnings.
  • Downloaded and verified the real pinned Maven archive, then ran it on Java 11 with Homebrew excluded from PATH: 178 JDBC unit tests and 1 Arrow unit test passed; 29 native Arrow tests were skipped in that local smoke run.
  • Upstream build run 44392568288 was still in progress when this PR was created.

Release safety / next step

This PR does not dispatch a release, upload artifacts to Maven Central, change release versions, or create a stable tag. After merge and successful CI, snapshot verification requires a new release.yml dispatch at the merged main SHA; rerunning the old failed run would keep using its original workflow checkout. Any new snapshot upload and stable publication remain separately confirmed actions.

Note

Add pinned, SHA-512-verified Maven bootstrap to CI publishing workflows

  • Adds setup-maven.sh, which downloads a version-pinned Apache Maven archive, verifies it against a pinned SHA-512 (with a shasum fallback), and refuses to extract on mismatch. It appends Maven's bin directory to GITHUB_PATH.
  • Runs the bootstrap in the Java unit-test, Java 26 compatibility, and platform build jobs in build.yml, and in the preflight, platform build, and artifact staging jobs in release.yml.
  • Expands the release-tooling test command to run every scripts/test_*.py file, which now includes the new installer test suite in test_setup_maven.py.
  • Documents the snapshot-validation status and waiver in release-readiness.md.
  • Risk: MavenSetupChecks.test_installs_without_using_system_maven places a failing mvn stub on PATH; any CI job that still relies on a system Maven rather than the bootstrap will break.

Macroscope summarized f737887.

@ShawnChen-Sirius
ShawnChen-Sirius merged commit 7cb8f73 into main Nov 18, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant