Repository navigation
Fix Arrow table registration with a Session - #103
Merged
Merged
Conversation
Contributor
Author
|
@wudidapaopao, please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session.connectioninstead of the nonexistentSession._handlewhen registering an Arrow table on an explicit session.Fixes #101
Supersedes #102 with an in-repository head branch so Macroscope can run.
Validation
npm run build:ts, all 12 Arrow-input tests, andactionlint .github/workflows/connection.ymlpass locally.Note
Fix Arrow table registration to use
Session.connectionand skip stale unregisterregisterArrowTablein arrow-input.ts now reads the native connection fromSession.connectioninstead ofSession._handle, and rejects a Session with no active connection.session.queryAsync, rejecting a closed Session, and repeatedclose()after a Session is closed.Macroscope summarized 9b59ba8.