Skip to content

Update to Node 24 - #15

Open
carlansley wants to merge 3 commits into
mainfrom
node24
Open

Update to Node 24#15
carlansley wants to merge 3 commits into
mainfrom
node24

Conversation

@carlansley

Copy link
Copy Markdown
Contributor

Fixes #14

@carlansley carlansley self-assigned this Aug 27, 2026
Copilot AI lite review requested due to automatic review settings August 27, 2026 21:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the package to a new major version and updates repository tooling to align with a minimum supported Node.js version of 24 (Issue #14), including CI and release workflows.

Changes:

  • Bump package major version to 4.0.0 and set engines.node to >=24.18.0.
  • Update memoization implementation/tests for newer runtimes (e.g., toSorted() usage) and refresh ancillary docs/legal headers.
  • Consolidate and modernize GitHub Actions workflows (publishing, coverage, CodeQL, CI matrix).

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/memoize.ts Uses newer JS APIs (toSorted) and narrows key-set typing while preserving cache-key behavior.
src/memoize.spec.ts Adjusts tests/lint disables and simplifies non-literal object type assertions.
src/index.ts Updates copyright year.
SECURITY.md Updates supported-version policy to >= 4.0.
README.md Updates copyright notice formatting/year.
package.json Major version bump, Node engine bump to 24+, script updates, and dev dependency bumps.
LICENSE.txt Updates copyright year.
.github/workflows/publish.yml Merges release + PR beta publishing into a single workflow and updates action versions.
.github/workflows/publish-beta.yml Removes the standalone beta publish workflow (now handled by publish.yml).
.github/workflows/coverage.yml Reworks coverage to compare base vs PR via separate jobs and artifact passing.
.github/workflows/codeql-analysis.yml Updates CodeQL action major version.
.github/workflows/ci.yml Updates Node test matrix to 24.x and 26.x and bumps action versions.
.github/workflows/check-published-scheduled.yml Updates schedule time and bumps action version.
Suppressed comments (1)

.github/workflows/coverage.yml:50

  • Same artifact path issue as the base job: uploading coverage/lcov.info will generally download as coverage-pr/coverage/lcov.info when path: coverage-pr is used in download-artifact, which can break the reporter that is configured with coverage-results-folder-pr: 'coverage-pr'. Upload the coverage directory instead so coverage-pr/lcov.info exists after download.
      - uses: actions/upload-artifact@v7
        with:
          name: pr-coverage
          path: coverage/lcov.info
          if-no-files-found: error

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/coverage.yml
Comment thread .github/workflows/check-published-scheduled.yml Outdated
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Coverage after merging node24 into main will be

99.26%▴ +0.02%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   index.ts100%100%100%100%
   memoize.spec.ts98.66%96.36%97.96%99.04%346–348, 371–373
   memoize.ts100%100%100%100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to minimum Node version 24

2 participants