Update to Node 24 - #15
Open
carlansley wants to merge 3 commits into
Open
Conversation
carlansley
had a problem deploying
to
npm-publish
August 27, 2026 21:40 — with
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR bumps the package to a new major version and updates repository tooling to align with a minimum supported Node.js version of 24 (Issue #14), including CI and release workflows.
Changes:
- Bump package major version to
4.0.0and setengines.nodeto>=24.18.0. - Update memoization implementation/tests for newer runtimes (e.g.,
toSorted()usage) and refresh ancillary docs/legal headers. - Consolidate and modernize GitHub Actions workflows (publishing, coverage, CodeQL, CI matrix).
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/memoize.ts |
Uses newer JS APIs (toSorted) and narrows key-set typing while preserving cache-key behavior. |
src/memoize.spec.ts |
Adjusts tests/lint disables and simplifies non-literal object type assertions. |
src/index.ts |
Updates copyright year. |
SECURITY.md |
Updates supported-version policy to >= 4.0. |
README.md |
Updates copyright notice formatting/year. |
package.json |
Major version bump, Node engine bump to 24+, script updates, and dev dependency bumps. |
LICENSE.txt |
Updates copyright year. |
.github/workflows/publish.yml |
Merges release + PR beta publishing into a single workflow and updates action versions. |
.github/workflows/publish-beta.yml |
Removes the standalone beta publish workflow (now handled by publish.yml). |
.github/workflows/coverage.yml |
Reworks coverage to compare base vs PR via separate jobs and artifact passing. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL action major version. |
.github/workflows/ci.yml |
Updates Node test matrix to 24.x and 26.x and bumps action versions. |
.github/workflows/check-published-scheduled.yml |
Updates schedule time and bumps action version. |
Suppressed comments (1)
.github/workflows/coverage.yml:50
- Same artifact path issue as the base job: uploading
coverage/lcov.infowill generally download ascoverage-pr/coverage/lcov.infowhenpath: coverage-pris used indownload-artifact, which can break the reporter that is configured withcoverage-results-folder-pr: 'coverage-pr'. Upload thecoveragedirectory instead socoverage-pr/lcov.infoexists after download.
- uses: actions/upload-artifact@v7
with:
name: pr-coverage
path: coverage/lcov.info
if-no-files-found: error
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
carlansley
had a problem deploying
to
npm-publish
August 27, 2026 21:54 — with
GitHub Actions
Failure
carlansley
requested a deployment
to
npm-publish
September 1, 2026 18:59 — with
GitHub Actions
Waiting
|
Coverage after merging node24 into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14