Repository navigation
CHEF-37251: Fix OTP 29 compiler warnings - #4
Draft
lbakerchef wants to merge 1 commit into
Draft
lbakerchef wants to merge 1 commit into
lbakerchef wants to merge 1 commit into
Conversation
OTP 29 warns on old-style catch and on matches that unify constructors; this fork builds with warnings_as_errors, so both fail the build. Port upstream erlware_commons v1.9.1 fixes for ec_talk:get_integer/1 and ec_date:do_parse/3. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Lincoln Baker <51833247+lbakerchef@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OTP 29 compatibility fix for the Chef Infra Server Erlang/OTP 26.2.5.21 -> 29.1.2 upgrade (CHEF-37251).
OTP 29 warns on old-style catch and on matches that unify constructors; this fork builds with warnings_as_errors, so both fail the build. Port upstream erlware_commons v1.9.1 fixes for ec_talk:get_integer/1 and ec_date:do_parse/3.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Signed-off-by: Lincoln Baker 51833247+lbakerchef@users.noreply.github.com
Based on
lbaker/fix_for_ftmap(the ref chef-server currently consumes), so this PR contains only the OTP 29 change.Related: chef/chef-server#4252, chef/omnibus-software-private#24