Repository navigation
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix pasting across hidden columns. Part of #59. Stacked on #74 (base
perf/engine-gaps).Problem
The rectangular paste fast path checked that the target data rows were contiguous, but not the target physical columns. With column B hidden, pasting a 2×2 block at column A built a 2-column
setBlockover the physical range A:C (3 columns). The engine rejects the dimension mismatch, so the paste silently changed nothing. Found during the 0.5.0 architecture review.Change
The packed path is used only when the target physical columns are contiguous and increasing. Otherwise the paste uses the existing per-cell transaction. Fill, history capture, inverse patches and batch slicing were checked: none maps view columns to a packed block.
Verification
createGridwith a realSheetwriteStore: hide column 1, paste a 2×2 TSV at column 0. Visible columns 0 and 2 receive the values, hidden column 1 stays unchanged, and one undo restores everything. It failed before the fix (cells unchanged) and passes after.