Repository navigation
Series sync: version fields, common/ 3.0.0, device rename, release-asset fix (v1.0.2) - #2
Merged
Merged
Conversation
…values
Both properties were hardcoded const strings ("1.0.0") in common/constants.go
and never updated as the example's real version advanced (same bug found and
fixed in the sibling BACnetProfileExample-B-SCHUB-CPP v1.1.13 via a real
device read with CAS BACnet Explorer).
Go's const cannot hold a runtime-only value (the stack's own version) or
reference a value from a package that imports it back (common cannot import
main, which imports common), so ApplicationSoftwareVersion and
FirmwareRevision moved from const to package-level var in
common/constants.go, with start-up placeholder defaults. main.go's run() now
sets both once, right after printVersion() confirms the cgo-linked native
library works, before the socket is bound or any callback is registered:
ApplicationSoftwareVersion <- appVersion; FirmwareRevision <- built from
bacnet.GetAPI{Major,Minor,Patch,Build}Version() (the same 4 calls
printVersion() already uses for the banner) - it names the underlying
platform, not this app.
Bumped appVersion to 1.0.1. Verified with `go build -o bacnet-b-ss-go.exe .`
(the README's documented build command - clean, no errors) and a real
ReadProperty via bacpypes3 against the running device:
Application_Software_Version = "1.0.1", Firmware_Revision = "6.0.21.0".
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Every example in the series announced the identical Object_Name "Rainbow" for its Device object, so two examples running on the same subnet were indistinguishable by name. Renamed to "Chipkin Example B-SS" (the series' BACnet profile code) so devices are identifiable on the network; sub-object names are unchanged. docs/colour-table.md (series root, not in this repo) updated to match. appVersion bumped 1.0.1 -> 1.0.2. gofmt -w re-aligned common/constants.go's const block after the longer value changed column widths. `go build ./...` still fails on the pre-existing, unrelated vendored-adapter header issue (submodules/cas-bacnet-stack/adapters/golang/CASBACnetStackAdapter.go: CASBACnetStackDLL.h not found) noted in an earlier session - not introduced by this change. Verified instead with `gofmt -l` (clean) and `go vet ./common/...` (clean). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… failure)
Every platform artifact carries the same docs (README.md, LICENSE,
TUTORIAL.md, ...), and the publish job handed all of them to
softprops/action-gh-release with `files: artifacts/**/*`. Uploading two
assets with the same name makes the action fail part-way ("Not Found"
updating asset metadata) and leaves a draft release behind -
BACnetProfileExample-B-SCHUB-CPP v1.1.18 hit exactly this.
The publish job now flattens the downloaded artifacts into release/,
keeping one copy of each file name, and fails loudly if two files share
a name but differ. Same asset set as before, each name once. Applied
series-wide (the release job is a shared template, checked by
tools/check-series.sh check 11).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
mainup to v1.0.2 with the series-wide changes made locally since the last merge:Summary:
Application_Software_VersionandFirmware_Revisionnow report the real app and stack versions (C++ repos).common/synced to 3.0.0, which merges the B-BC and B-SCHUB forks (C++ repos).docs/objects.jsonand PICS are updated to match.Each rebuild was version-bumped and live-verified locally at commit time (startup banner shows the new Device name). See
CHANGELOG.md.🤖 Generated with Claude Code